A saved address breaks checkout
Three customers reported checkout getting stuck this morning. I’m checking whether they’re hitting the same error.
Thanks. Send me the issue so I can keep them updated.
All three reports match the same checkout error in Sentry. I can reproduce it with a saved address.
That matches what the customers are seeing.
@Parall-dev, ENG-218 has the repro and Sentry trace. Can you take the fix?
On it. I’ll add a regression test and open a PR.
Saved-address checkout
Checkout fails before payment begins when a returning customer uses a saved address.
@Parall-dev, ENG-218 has the repro and Sentry trace. Can you take the fix?
On it. I’ll add a regression test and open a PR.
@Erik, PR #84 is ready. Saved addresses now work, and the regression test passes.
Thanks, reviewing now.
Fix saved-address checkout
Fixes ENG-218
Saved addresses use an address ID. Checkout was reading the new-address form and tried to read a missing postal code.
Resolve the saved address before building the request.
− const address = values.shippingAddress;+ const address = resolveShippingAddress(values);
Intercom
Sentry
Linear
GitHub